[Feature] Introducing un-safe plugin installation #4039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Why was this closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Yarn prints warnings messages (e.g deprecated dependencies, custom library messages) on the stderr and Insomnia erroneously treat them as installation errors.
What this PR aims for
Resolve the edge cases which may prevent a plugin to be installed just for a couple of warnings.
What is this "unsafe" mode all about
Insomnia executes its own plugin installation as always ... but skips the stderr check on its last step.
Implementation
The user can only install un-safely when he gets an installation failure that failed when the plugin reached the stderr check.
Showcase
As always feedback are welcome.