adds ndjson language support extension #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
commented
Sep 21, 2021
| { | ||
| "files.associations": { | ||
| "*.db": "ndjson", | ||
| "*.jsonl": "ndjson", |
There was a problem hiding this comment.
in case anyone else is/was curious ndjson/ndjson.github.io#1 (comment) shows the relationship between JSON Lines and ndjson.. lol... what's that xkcd for this, again?
dimitropoulos
commented
Sep 21, 2021
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "files.associations": { | |||
There was a problem hiding this comment.
this is a copy-pasta from what's in the docs for the plugin https://github.com/AdrieanKhisbe/vscode-ndjson
Arguably, the .db entry is the only one we need, but I figured it can't hurt to keep the other ones, too.
develohpanda
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing an answer in #3786 (comment) I realized that we'd benefit from just including this extension.
Our database files are newline-delimited JSON (http://ndjson.org/), the native format of NeDB.
It's often enough, at least for me, that I look at a data file, so I thought this would be useful to others as well.