chore: skip build:sr in bootstrap and app-build #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
changed the title
filfreire
approved these changes
Jun 6, 2022
jackkav
force-pushed
the
chore/remove-sr-from-app-dx
branch
from
f7b45ce
to
0e23939
Compare
davidfluck-kong
added a commit
that referenced
this pull request
Aug 12, 2022
This reverts commit 70f8e7f.
davidfluck-kong
added a commit
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we build send-request unnecessarily in bootstrap. This would save some time.
This PR moves send-request build (
build:sr) triggering out of bootstrapping and app build, to just inso dx and inso packaging. This change helps send-request from interfering with the insomnia app dx happy path, while still ensuring it runs in documented dx's.