Fix/linux deep link #5377
Merged
Fix/linux deep link #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
force-pushed
the
fix/linux-deep-link
branch
from
5c2c3af
to
860d94a
Compare
filfreire
approved these changes
Nov 3, 2022
|
Unfortunately, this PR appears to have broken the ability to open a second Insomnia instance (#5761 ). New windows will now fail to open with "Failed to get instance lock", at least in MacOS, presumably in Windows as well, judging from the comments in that issue. Oddly, downloading version 2022.6.0 results in the ability to open a second window again, but it still gets that error in the console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue that prevented deep link redirects from browser to app (e.g. Login, installing Plugins, ...) to not work properly on Windows and Linux.
fixing
insomnia://app/import?uri=http://gist.com/my.jsonand github signin deep links in windows and linuxCloses INS-2067
Possibly also:
Closes #5282
Closes INS-2116
Note - microsoft/vscode#97626