Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/linux deep link #5377

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Fix/linux deep link #5377

merged 9 commits into from
Nov 3, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Nov 3, 2022

changelog(Fixes): Fixed an issue that prevented deep link redirects from browser to app (e.g. Login, installing Plugins, ...) to not work properly on Windows and Linux.

fixing insomnia://app/import?uri=http://gist.com/my.json and github signin deep links in windows and linux

Closes INS-2067

Possibly also:
Closes #5282
Closes INS-2116

Note - microsoft/vscode#97626

@jackkav jackkav requested a review from a team November 3, 2022 11:41
@jackkav jackkav marked this pull request as ready for review November 3, 2022 11:41
@jackkav jackkav marked this pull request as draft November 3, 2022 14:03
@jackkav jackkav marked this pull request as ready for review November 3, 2022 16:44
@jackkav jackkav enabled auto-merge (squash) November 3, 2022 17:03
@jackkav jackkav merged commit 61e1a59 into Kong:develop Nov 3, 2022
@jackkav jackkav deleted the fix/linux-deep-link branch November 3, 2022 17:11
@tlund101
Copy link

tlund101 commented May 24, 2023

Unfortunately, this PR appears to have broken the ability to open a second Insomnia instance (#5761 ). New windows will now fail to open with "Failed to get instance lock", at least in MacOS, presumably in Windows as well, judging from the comments in that issue.

Oddly, downloading version 2022.6.0 results in the ability to open a second window again, but it still gets that error in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insomnia App urls "insomnia://" redirect not working on Windows
3 participants