Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gql oauth - revert to libcurl #5611

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jan 4, 2023

changelog(Fixes): Fixed multiple issues with GraphQL schema fetching, introspection and GraphQL requests that required OAuth2 and other types of Authentication

reverts the change to axios for schema fetching, since oauth2 adds a transparent header.
closes INS-2221

@jackkav jackkav requested a review from a team January 4, 2023 19:38
@jackkav jackkav changed the title fix: gql oauth - use libcurl fix: gql oauth - revert to libcurl Jan 4, 2023
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@filfreire filfreire merged commit 9e1e05a into Kong:develop Jan 5, 2023
@jackkav jackkav deleted the revert/gql-editor-schema-fetch branch January 5, 2023 10:40
kreosus pushed a commit to kreosus/insomnia that referenced this pull request Jan 10, 2023
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants