Fixed/issue 5692 - Show autocomplete in GraphQL #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
force-pushed
the
fix/issue-5692
branch
from
4c7f0d2
to
3da1ae2
Compare
filfreire
approved these changes
Jul 14, 2023
|
@gatzjames @jackkav I think this one is good to be merged. Reprodution is pressing CTRL+Space to get the Graphql Query autocomplete suggestions on demand. |
|
Looks like a meaningful ubuntu smoke test is failing |
|
The test that fails seems to be a timeout unrelated to this merge request... |
jackkav
force-pushed
the
fix/issue-5692
branch
from
aac34e2
to
dd5e377
Compare
jackkav
approved these changes
Aug 30, 2023
|
@u1aryz you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
|
this 'fix' broke the autocomplete showing when we only pressing space. Please revert. or maybe make that an option in settings for auto complete population... to choose CTRL+space or just space |
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed issue #5692 where cmd+space wasn't showing all GQL options
This PR closes #5692
Fixed a bug that prevented autocomplete shortcut keys from working in GraphQL.