Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INS-2639: add kong 3.x support for inso generate k8s config #5977

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented May 18, 2023

changelog(Improvements): Added minor Kong 3.x support for generating k8s configs using Inso CLI

While ApiOps v2 is not in full GA/production yet, adding this small QoL improvement to config generation to unblock folks still using Inso CLI for kong on k8s config generation cc @mheap @rspurgeon

@filfreire filfreire requested review from mheap, rspurgeon and a team May 18, 2023 13:41
filfreire and others added 2 commits May 18, 2023 15:13
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still don't agree with legacy defaulting to true, but since this feature is moving to a Go implementation, I'm happy to approve one liners.

@filfreire filfreire added this pull request to the merge queue May 22, 2023
Merged via the queue into Kong:develop with commit 1b87404 May 22, 2023
9 checks passed
@filfreire filfreire deleted the feature/ins-2639-minor-update-to-k8s-config-gen-on-inso branch May 22, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants