fix #5976: set content-type on openapi3 imports #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jackkav
reviewed
May 22, 2023
Comment on lines
293
to
307
| header => header.name === 'Content-Type', | ||
| ); | ||
|
|
||
| // @ts-expect-error -- ?? | ||
| if (body && body.mimeType && noContentTypeHeader) { | ||
| paramHeaders = [ | ||
| { | ||
| name: 'Content-Type', | ||
| disabled: false, | ||
| // @ts-expect-error -- ?? | ||
| value: body.mimeType, | ||
| }, | ||
| ...paramHeaders, | ||
| ]; | ||
| } |
There was a problem hiding this comment.
since it doesn't appear to mutate the body, would it make sense for this logic to belong inside prepareHeaders()?
There was a problem hiding this comment.
sounds good to me - moved it inside to prepareHeaders 👍
filfreire
force-pushed
the
fix/issue-5976-set-contenttype-oa3-import
branch
from
3e55ee8
to
c6a40c3
Compare
jackkav
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5976
Related to similar past change - #5812
If mime type is set for bodies in the OpenAPI imported spec, we now set the content-type on the generated requests as well.
changelog(Fixes): Added a fix to help set Content-Type header when importing requests from OpenAPI 3 specs of which the mime-type was already specified