gRPC: Support JSONPath filter for response body #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianjonasson
changed the title
sebastianjonasson
force-pushed
the
grpc/json-path-response-2
branch
from
cd5cd0d
to
0656415
Compare
|
Really wish Insomnia would eventually move away from JSONPath towards something more functional and backwards compatible like JSONata |
|
@jackkav - Could I also get you to take a look at PR? |
|
@jackkav @filfreire @gatzjames @pavkout - Would appreciate some feedback on this PR as well. Thanks! |
jackkav
approved these changes
Jul 14, 2023
|
Thanks for the contribution, would be great to support something besides JSONPath too. jq has also been suggested but would require another native module which we aren't open to right now, but JSONata seems easier to adopt. It's not on our list right now but would be happy to help push forward a community contribution! |
|
@sebastianjonasson you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
jackkav
pushed a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Improvements): Added support for JSONPath queries for gRPC responses.
Description
Add support for JSONPath queries for gRPC responses bodies.
Currently the JSONPath filter input is rendered in the gRPC response tab, but does not apply the entered filter. This PR adds support for JSONPath filter by copying the current behavior of the response pane for http requests.
Type of change
Trivial change. Everything was already in place, just needed to copy the handler for applying the query.
How Has This Been Tested?
Manually tested using Insomnia UI on Ubuntu 22.04:
Using develop branch:
Checking out this PR: