Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pkg #6001

Merged
merged 6 commits into from Jun 29, 2023
Merged

upgrade pkg #6001

merged 6 commits into from Jun 29, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented May 30, 2023

reproducing the UNEXPECTED-15 from pkg 5.8.1

highlights:

  • removes pkg.ts pkg package and related indirection by simply using npx
  • remove unused smoke test commands, speeding up bootstrap
  • problem could occur again if tslib falls out of sync
  • remove platform selection logic and use host from pkg docs to infer platform and architecture for build

quick repro:
5.3.2 works

npx -y pkg@5.3.2 -d $PWD/packages/insomnia-inso --targets node16-macos-x64 --output $PWD/packages/insomnia-inso/binaries/inso && \
$PWD/packages/insomnia-inso/binaries/inso run test "Echo Test Suite" --src $PWD/packages/insomnia-smoke-test/fixtures/inso-nedb --env Dev --verbose

5.3.3 - 5.5.2 gives error

Error: dlopen(/var/folders/px/k64bm1y957d6xs5_jm6fsgh80000gn/T/pkg/c3dafd0cfbab527bf033335358949e224ee2f625d5f9034da4397283fc55e637/@getinsomnia/node-libcurl/lib/binding/node_libcurl.node, 0x0001): tried: '/var/folders/px/k64bm1y957d6xs5_jm6fsgh80000gn/T/pkg/c3dafd0cfbab527bf033335358949e224ee2f625d5f9034da4397283fc55e637/@getinsomnia/node-libcurl/lib/binding/node_libcurl.node' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/var/folders/px/k64bm1y957d6xs5_jm6fsgh80000gn/T/pkg/c3dafd0cfbab527bf033335358949e224ee2f625d5f9034da4397283fc55e637/@getinsomnia/node-libcurl/lib/binding/node_libcurl.node' (no such file), '/var/folders/px/k64bm1y957d6xs5_jm6fsgh80000gn/T/pkg/c3dafd0cfbab527bf033335358949e224ee2f625d5f9034da4397283fc55e637/@getinsomnia/node-libcurl/lib/binding/node_libcurl.node' (no such file)

5.6.0 - 5.8.1 doesn't work

npx -y pkg@5.8.1 -d $PWD/packages/insomnia-inso --targets node16-macos-x64 --output $PWD/packages/insomnia-inso/binaries/inso && \
$PWD/packages/insomnia-inso/binaries/inso run test "Echo Test Suite" --src $PWD/packages/insomnia-smoke-test/fixtures/inso-nedb --env Dev --verbose

the problem was:
tslib being added within the node-libcurl node_module was causing pkgs new copy logic to fallover once I removed tslibs module override behaviour by adding it to send-request the problem when away

changelog(Fix): Added workaround to tslib/pkg bugthat was causing inso bundling to silently fail.:

@jackkav jackkav marked this pull request as ready for review June 29, 2023 14:56
@jackkav jackkav enabled auto-merge June 29, 2023 15:01
@jackkav jackkav requested a review from gatzjames June 29, 2023 15:01
@jackkav jackkav self-assigned this Jun 29, 2023
@jackkav jackkav requested a review from a team June 29, 2023 15:25
@jackkav jackkav disabled auto-merge June 29, 2023 15:25
@jackkav jackkav merged commit 20b4556 into Kong:develop Jun 29, 2023
9 checks passed
@jackkav jackkav deleted the chore/upgrade-pkg branch June 29, 2023 15:25
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
* include debug instructions

* remove pkg as a dependency

* fix doc

* add tslib to send-request to fix libcurl pkg bs

* bump pkg to 5.8.1

* remove not needed scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants