Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore oAuth2 exception on redirect of initial url load (#5926) #6120

Merged
merged 2 commits into from Jul 14, 2023

Conversation

chrisjq
Copy link
Contributor

@chrisjq chrisjq commented Jul 8, 2023

Ignore exception on child.loadURL(url) where the exception is caused by a redirect. Closes #5926.

changelog(Fixes): Fixed an issue where Insomnia would crash when opening an OAuth2 authorization window.

@jackkav jackkav added this pull request to the merge queue Jul 14, 2023
Merged via the queue into Kong:develop with commit 80502e9 Jul 14, 2023
9 checks passed
@chrisjq chrisjq deleted the fix_oauth2_redirect branch July 16, 2023 02:23
@filfreire
Copy link
Member

@chrisjq you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
…) (Kong#6120)

* fix: Ignore oAuth2 exception on redirect of initial url load (Kong#5926)

* use if

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash using OAuth2 authorization
3 participants