New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Allow empty name when duplicate request #6138
Conversation
5842005
to
498c6eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, however its debatable that we should allow empty request names as it could cause some confusion, but then we would need validation. Thanks.
@pilotpirxie @jackkav this will cause a few unhandled cases in terms of user experience, for example Rename which also uses prompt modal: |
closes #6035 |
We could add |
@filfreire Screen.Recording.2023-07-14.at.12.46.21.mov |
@jackkav so, can it be merged? Checks have passed but I don't have permission to merge |
@pilotpirxie you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
changelog(Improvements): Empty strings are now allowed when duplicating a request.
When duplicating request, an empty prompt with a name can be accepted but it's not processed. Insomnia handles empty names and displays the entire URL. Not handling empty names looks there like a bad user experience.
This PR allows proceeding with an empty string when duplicating a request.