Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE/EventStream support #6147

Merged
merged 38 commits into from Jul 19, 2023
Merged

SSE/EventStream support #6147

merged 38 commits into from Jul 19, 2023

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 13, 2023

changelog(New Features): Added SSE/EventStream request support.

motivation: the community asked for this Jan' 2019 #3713

todo

  • create request
  • wire up libcurl
  • wire up response pane
  • response listener
  • old request cleanup
  • timeline listener
  • flatten response panes into a single component?
  • placeholders
  • stablise timeline while connected

future work

  • use eventsource api to enrich the stream parsing
  • try curly - figure out the tradeoffs
  • try to refactor the curl promise and the listener
  • improve the logs for log clean up

@jackkav jackkav requested a review from a team July 19, 2023 07:38
@jackkav jackkav marked this pull request as ready for review July 19, 2023 07:38
@jackkav jackkav added this pull request to the merge queue Jul 19, 2023
Merged via the queue into Kong:develop with commit 3cdd4c8 Jul 19, 2023
9 checks passed
@jackkav jackkav deleted the feat/sse branch July 19, 2023 10:11
jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
* new request

* add button

* s

* fix formatting issue

* detect event stream

* hide dropdown

* wip

* add basic test

* pass 1 can make connection

* implement event stream open pass 2

* wire up ready state

* wiring up close and error pass 3

* can open and close connections

* clean header

* listen to timeline

* extract options to function

* fix bug in ws

* add debug stuff to timeline

* don't rely on redux to set active response

* fix close type

* rename sse to event stream

* get request flag from request model

* copy websocket response pane

* hide response data

* flatten ws and curl responses

* fix test

* fix catch

* reset file

* use realtime event watcher

* rename some files

* fix types

* fix e2e test

* fix lint

* consistent empty states

* pin to bottom

* remove todo

* add SSE logo

* add sse to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants