Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right click on row to show request actions #6275

Merged
merged 1 commit into from Aug 15, 2023
Merged

Conversation

ASchwad
Copy link
Contributor

@ASchwad ASchwad commented Aug 14, 2023

changelog(Fixes): Fixed an issue where request actions can be opened with a right-click.

Currently the actions of a request can only be opened by directly clicking the ▾ symbol. It would enhance the UX to also show this context menu on right click.

Upon checking the code, it seems like this was originally / earlier also intended as there already exists this snippet in sidebar-request-row.tsx which is called upon right clicking on a row.
Therefore I assume this is rather a fix than a feature - but please let me know if I should rather open an issue before.

@ASchwad
Copy link
Contributor Author

ASchwad commented Aug 14, 2023

Ah found an issue for this: #5738

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @pavkout @gatzjames any suggestions?

@jackkav jackkav enabled auto-merge (squash) August 15, 2023 15:09
@jackkav jackkav merged commit 8b642ea into Kong:develop Aug 15, 2023
7 checks passed
@filfreire
Copy link
Member

@ASchwad you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution

jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants