Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #6304 git clone collections #6333

Merged
merged 4 commits into from Aug 18, 2023
Merged

fix: #6304 git clone collections #6333

merged 4 commits into from Aug 18, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Aug 18, 2023 •
edited

changelog(Fixes): Fixed issue #6304 where cloning git synced collections wasn't working properly

Closes #6304

When we git cloned we were hard-coding design as scope in some places. In this PR we try to fix that and also fix the route that we redirect to when we clone/re-clone.

Useful repos to use when testing this PR:

@filfreire filfreire requested a review from a team August 18, 2023 14:59
@filfreire filfreire requested a review from jackkav August 18, 2023 15:54
@jackkav jackkav merged commit 97e21a2 into develop Aug 18, 2023
7 checks passed
@jackkav jackkav deleted the fix/issue-6304-git-clone-collections branch August 18, 2023 19:06
jackkav pushed a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
@filfreire @jackkav
fix: Kong#6304 git clone collections (Kong#6333)
af678dd 
* fix: Kong#6304 git clone collections

* rm n/a test

* redirect to /debug on reclone

* simplify code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git clone existing Insomnia collection from repository fails
2 participants
@filfreire @jackkav