New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup second pass #6388
backup second pass #6388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked on mac and windows
EDIT: @jackkav restore seems to restore everything back to how it was - but it would close the app right away when running and I had to restart the App by hand, not sure if that is by design
I don't understand your meaning can you clarity please |
@jackkav when I called the restore backup via dev tools - the app would close and not start again |
0594ead
to
ae3dcf4
Compare
* some notes on approach * some broken fs logic * some more broke stuff * fix backup logic * rename export to backup * wire up a restore * restore check * only update if newer version * extract to function * rename export to backup
changelog(Improvements): Provide local data backup for all platforms after app start.
motivation: provide data backup for all platforms, after app start to version folder
goal: check remote for new version shortly after app start, if found, start backup process if not already done.
~/Library/Application Support/insomnia-app/backups
also testable in dev console with