fix api version error #6493
Merged
fix api version error #6493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Sep 13, 2023
filfreire
reviewed
Sep 13, 2023
| @@ -877,7 +877,7 @@ const ProjectRoute: FC = () => { | |||
| {item.workspace.name} | |||
| </Heading> | |||
| <div className="flex-1 flex flex-col gap-2 justify-end text-sm text-[--hl]"> | |||
| {item.spec?.info?.version && ( | |||
| {typeof item.spec?.info?.version === 'string' && ( | |||
There was a problem hiding this comment.
Wonder if the version can be a number?
There was a problem hiding this comment.
the v prefix is trivial ui sugar. Not worth adding more conditions to
1 task
bernd
pushed a commit
to bernd/unetus
that referenced
this pull request
Sep 30, 2023
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6465
changelog(Fixes): Fixed issue #6465 where a render error would be through in some cases depending on the version format of an OpenAPI spec