fix: unable to refer numeric environments in GQL variables [INS-3256] #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihexxa
force-pushed
the
fix-vars-store
branch
from
29c65f5
to
922e846
Compare
ihexxa
changed the title
ihexxa
force-pushed
the
fix-vars-store
branch
from
922e846
to
0879262
Compare
|
@jackkav @gatzjames pls let me know if it makes sense to you then we can push this forward. |
|
So it was persisted as an object before and now it's a string. If that's the only change it's cool to go forward. Watch out for small ux changes that came from the json parser like validation ux |
ihexxa
changed the title
|
Good point and yes, this is only the change. |
jackkav
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
changelog(Fixes): Fixed an issue where referencing numeric variables in GraphQL queries would not work as expected.