Fix: deleting a key combination #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Nov 22, 2023
gatzjames
force-pushed
the
fix/remove-keyboard-shortcut
branch
from
b4b8c74
to
edaed80
Compare
ihexxa
approved these changes
Nov 22, 2023
| if (areSameKeyCombinations(existingKeyComb, keyComb)) { | ||
| toBeRemovedIndex = index; | ||
| } | ||
| }); | ||
| if (toBeRemovedIndex >= 0) { | ||
| keyCombosForThisPlatform.splice(toBeRemovedIndex, 1); | ||
| keyCombs.splice(toBeRemovedIndex, 1); |
There was a problem hiding this comment.
nit: just out of curious, where is the keyCombs consumed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a key combination doesn't work.
This PR mutates the appropriate list of combinations that we pass to update the settings.
Next steps:
changelog(Fixes): Fixed an issue where removing an existing keyboard shortcut would not work as expected