Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prereq): add simple timeout #7079

Merged
merged 10 commits into from
Mar 1, 2024
Merged

feat(prereq): add simple timeout #7079

merged 10 commits into from
Mar 1, 2024

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Feb 9, 2024 •
edited
Loading

todo

  • add a timeout on the hidden browser side
  • decide on a configuration ux, global and/or per request? we could use request timeout 30s from global settings as a stop gap
  • show/hide hidden browser window
  • create a second timeout which is intended to catch communication issues with the hidden browser window
    maybe:
  • use an abort controller to stop executing the script after timeout
  • an e2e test case

closes INS-3562

@jackkav jackkav changed the title feat: add simple timeout feat(prereq): add simple timeout Feb 11, 2024
@jackkav jackkav force-pushed the feat/pre-req-timeout branch 2 times, most recently from 9a8e125 to 5be0a0c Compare February 13, 2024 09:48
@jackkav jackkav force-pushed the feat/pre-req-timeout branch 2 times, most recently from 5d34051 to 822d71a Compare March 1, 2024 11:37
@jackkav jackkav marked this pull request as ready for review March 1, 2024 11:57
@jackkav jackkav merged commit 6d5b2a6 into Kong:develop Mar 1, 2024
7 checks passed
@jackkav jackkav deleted the feat/pre-req-timeout branch March 1, 2024 12:17
jackkav added a commit to jackkav/insomnia that referenced this pull request Mar 13, 2024
@jackkav
feat(prereq): add simple timeout (Kong#7079)
56e9539 
* add simple timeout

* configurable timeout

* use label for workspace cards

* toggle visible

* add stop

* second timeout

* add test

* fix lint

* exclude from eslint

* fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackkav @filfreire