feat(Insomnia Cloud Sync): Update filesystem driver for VCS sync #7111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await fs.writeFile(tmpPath, value, 'utf8'); | ||
| await fs.rename(tmpPath, finalPath); | ||
| } catch (err) { | ||
| console.error(`[FileSystemDriver] Failed to write to ${tmpPath} then rename to ${finalPath}`, err); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring Note
jackkav
reviewed
Feb 26, 2024
jackkav
previously approved these changes
Feb 26, 2024
jackkav
reviewed
Feb 26, 2024
gatzjames
force-pushed
the
feat/improve-file-system-driver
branch
from
c7a3da2
to
c73ac2b
Compare
filfreire
approved these changes
Feb 27, 2024
gatzjames
force-pushed
the
feat/improve-file-system-driver
branch
from
c73ac2b
to
e2b9dbe
Compare
gatzjames
force-pushed
the
feat/improve-file-system-driver
branch
from
e2b9dbe
to
0bab544
Compare
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Mar 13, 2024
…g#7111) * use fs/promises and uuid instead of math.random * Update packages/insomnia/src/sync/store/drivers/file-system-driver.ts * Update packages/insomnia/src/sync/store/drivers/file-system-driver.ts --------- Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Closes INS-3453