Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URL PREVIEW cut off first few lines for very long URL [INS-3640] #7190

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: URL PREVIEW cut off first few lines for very long URL [INS-3640] #7190

merged 2 commits into from
Mar 19, 2024

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Mar 19, 2024 •
edited
Loading

Closes #7178

Change

  • delete the wrapper alignItems style
  • use margin auto to keep vertical center

How to test

  • Enter a long URL. When it exceeds the maximum height of the URL preview box, it can slide normally to top.

@CurryYangxx CurryYangxx requested review from ihexxa and a team March 19, 2024 07:07
marckong
marckong reviewed Mar 19, 2024
View reviewed changes
packages/insomnia/src/ui/components/rendered-query-string.tsx
@@ -82,7 +82,7 @@ export const RenderedQueryString: FC<Props> = ({ request }) => {

return (
<Wrapper>
<span className={className}>{previewString}</span>
<span className={classNames('my-auto', className)}>{previewString}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Is there a reason for using my-auto as the class name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be from tailwind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

marckong
marckong approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@marckong marckong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I may suggest if we add screenshot, it would help reviewers who haven't touched the codebase for a while (:p) to understand the changes

@CurryYangxx
Copy link
Member Author

LGTM. I may suggest if we add screenshot, it would help reviewers who haven't touched the codebase for a while (:p) to understand the changes

Good idea, I will add screenshots in future PRs

@CurryYangxx CurryYangxx merged commit b7a078d into develop Mar 19, 2024
7 checks passed
@CurryYangxx CurryYangxx deleted the fix/url-preview-cut-off branch March 19, 2024 09:42
@CurryYangxx CurryYangxx changed the title fix: URL PREVIEW cut off first few lines for very long URL fix: URL PREVIEW cut off first few lines for very long URL [INS-3640] Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihexxa ihexxa ihexxa approved these changes

@marckong marckong marckong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL PREVIEW cut off first few lines for very long URL
3 participants
@CurryYangxx @ihexxa @marckong