Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable external modules in pre-request script - INS-3379 #7257

Merged
merged 2 commits into from
Apr 15, 2024
Merged

feat: enable external modules in pre-request script - INS-3379 #7257

merged 2 commits into from
Apr 15, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 11, 2024 •
edited
Loading

Background

This change does several things:

  • enable external modules for pre-request scripts
  • add tests

And this change also resolves several concerns:

  • these external dependencies can be accessed from main renderer but they are not used by it
  • these external dependencies increase main renderer bundle size
  • these external dependencies should be isolated with others, so that are able to manage those dependencies' version
  • no performance regression is detected

@ihexxa ihexxa marked this pull request as draft April 11, 2024 02:42
@ihexxa ihexxa self-assigned this Apr 11, 2024
@ihexxa ihexxa force-pushed the pre-req-workspace branch 2 times, most recently from 64c3deb to 5c4594c Compare April 12, 2024 13:03
Base automatically changed from pre-req-workspace to develop April 12, 2024 14:24
@ihexxa ihexxa marked this pull request as ready for review April 15, 2024 03:14
@jackkav jackkav merged commit 6c63b0d into develop Apr 15, 2024
7 checks passed
@jackkav jackkav deleted the pre-req-external-mods branch April 15, 2024 08:14
@jackkav jackkav mentioned this pull request Apr 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

@gatzjames gatzjames Awaiting requested review from gatzjames

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ihexxa @jackkav