Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some UI improvements of the pre-request script tab - INS-3711 #7258

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 11, 2024

Changes:

  • add green dot to pre-request script and doc tab when they are active
  • re-org and add script snippet menu items

Snapshots:

Menu Items:

Screenshot 2024-04-11 at 11 28 05

Tab title:

Screenshot 2024-04-11 at 14 57 08

@ihexxa ihexxa self-assigned this Apr 11, 2024
@ihexxa ihexxa changed the title fix: some UI improvements of pre-request script tab fix: some UI improvements of the pre-request script tab Apr 11, 2024
@ihexxa ihexxa requested a review from a team April 11, 2024 03:41
@ihexxa ihexxa changed the title fix: some UI improvements of the pre-request script tab fix: some UI improvements of the pre-request script tab - INS-3711 Apr 11, 2024
@ihexxa ihexxa marked this pull request as draft April 11, 2024 03:47
@ihexxa ihexxa marked this pull request as ready for review April 11, 2024 03:53
@CurryYangxx
Copy link
Member

I think it would look nicer if the dot could be aligned horizontally with the text

@ihexxa
Copy link
Contributor Author

ihexxa commented Apr 11, 2024

I think it would look nicer if the dot could be aligned horizontally with the text

Sounds reasonable, updated.

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@ihexxa ihexxa enabled auto-merge (squash) April 11, 2024 07:13
@ihexxa ihexxa merged commit c920055 into develop Apr 11, 2024
7 checks passed
@ihexxa ihexxa deleted the pre-req-ui-tick branch April 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants