Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some minor fixes for the pre-request script #7299

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: some minor fixes for the pre-request script #7299

merged 2 commits into from
Apr 23, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 23, 2024 •
edited
Loading

Changes:

  • avoid registering handler more than one time
  • gql request body is not set when updating request body in gql way
  • collectionVariables should share same data with the baseEnvironment

@ihexxa ihexxa self-assigned this Apr 23, 2024
@ihexxa ihexxa changed the title fix: minor fixes such as multiple registing and gql request body modification fix: some minor fixes for the pre-request script Apr 23, 2024
@jackkav jackkav merged commit 7cfead4 into develop Apr 23, 2024
7 checks passed
@jackkav jackkav deleted the fix-pre-req-minor-issues branch April 23, 2024 10:18
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 8, 2024
@ihexxa @stefancruz
fix: minor fixes such as multiple registing and gql request body modi…
27e2959 
…fication (Kong#7299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ihexxa @jackkav