Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable extended assertion chains on insomnia.response #7396

Merged
merged 4 commits into from
May 14, 2024
Merged

feat: enable extended assertion chains on insomnia.response #7396

merged 4 commits into from
May 14, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented May 13, 2024 •
edited

Closes: INS-3824

Changes:

  • feat: enable extended assertion chains on insomnia.response
  • add unit tests

@ihexxa ihexxa self-assigned this May 13, 2024
CurryYangxx
CurryYangxx reviewed May 13, 2024
View reviewed changes
packages/insomnia/src/ui/components/editors/request-script-editor.tsx Outdated
onClick={() => addSnippet(getCookies)}
/>
</DropdownItem>
</Dropdown>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an data array to generate these DropdownItems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, which will reduce some duplications. They are kept because sometimes we add components like DropdownSections which might need additional efforts to map them.

@ihexxa ihexxa merged commit e81550e into post-script-integration May 14, 2024
7 checks passed
@ihexxa ihexxa deleted the post-script-assert branch May 14, 2024 08:27
ihexxa added a commit that referenced this pull request May 15, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
ce8e0c4 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
@ihexxa ihexxa mentioned this pull request May 15, 2024
Merged
ihexxa added a commit that referenced this pull request May 15, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
97a6888 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 20, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
86ca899 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 22, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
a3ebf95 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
jackkav added a commit that referenced this pull request May 22, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
301a9d1 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 23, 2024
@ihexxa @jackkav
feat: enable major features of the after-response script (#7411)
46b6ea8 
* feat: update data model and request-pane to support post-req-script

* fix: unit test failed

* feat: integrate post-request script to the engine - INS-3785,INS-3786 (#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>

* test: add tests for post-request scripts and post-request scripts - INS-3786 (#7331)

* test: add some tests for post-req script and script engine

* fix: incorrect script type

* chore: refresh package-lock after merging

* chore: clean up package-lock.json

* fix: failed tests after rebasing

* feat: support importing post-req script from Postman (#7423)

* feat: support importing post-req script from Postman

* fix: introduce post-req script property for merged changes

* test: add a test case for importing scripts

* fix: add missing fixture

* chore: remove row after merging

* chore: rename to after-response-script

* fix test

* refresh lock

* update snapshot

* extract pre request logic to function

* refresh lock again

* throw on base env

* fix: revert the logic which rejects the case of unselected environment

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurryYangxx CurryYangxx CurryYangxx approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ihexxa @CurryYangxx