Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accessibility): Update request lists to anounce the request name of a request on voice over #7449

Merged
merged 5 commits into from
May 27, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented May 23, 2024

Highlights:

  • Hide the tag label since from aria since it gets anounced instead of the aria label. The tag is for presentation only.

Testing:
Tested on macOS using voice-over (cmd + F5) and navigated to the list of requests

Closes #7415

@gatzjames gatzjames requested a review from a team May 23, 2024 09:52
@gatzjames gatzjames self-assigned this May 23, 2024
jackkav
jackkav previously approved these changes May 23, 2024
@gatzjames gatzjames requested a review from jackkav May 23, 2024 18:44
@gatzjames gatzjames merged commit 9f0bd8b into Kong:develop May 27, 2024
7 checks passed
@gatzjames gatzjames deleted the fix/collection-aria-labels branch May 27, 2024 07:54
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[accessibility] Can't read request name in the table with screen reader
2 participants