Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: io-parallelization [INS-3911] #7458

Merged
merged 3 commits into from
May 30, 2024
Merged

perf: io-parallelization [INS-3911] #7458

merged 3 commits into from
May 30, 2024

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented May 28, 2024 •
edited
Loading

io operation Parallelization

Changes:

  • first fetch
  • orgs sync
  • project migration
  • collections fetch

Todo:

  • Compare the loading time before and after

@CurryYangxx CurryYangxx marked this pull request as draft May 28, 2024 07:47
@CurryYangxx CurryYangxx force-pushed the perf/poor-network-improvement branch from 5a189ff to 2070f38 Compare May 28, 2024 07:51
@CurryYangxx CurryYangxx changed the title perf/io-parallelization perf: io-parallelization [INS-3911] May 28, 2024
@CurryYangxx CurryYangxx marked this pull request as ready for review May 29, 2024 08:07
@CurryYangxx CurryYangxx requested a review from a team May 29, 2024 08:09
gatzjames
gatzjames approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything looks good!
It's worth adding some timing logs to check any performance improvements

@CurryYangxx
Copy link
Member Author

Tested and everything looks good! It's worth adding some timing logs to check any performance improvements

Good advice! I will add in additional pr

@CurryYangxx CurryYangxx enabled auto-merge (squash) May 30, 2024 13:21
@CurryYangxx CurryYangxx merged commit 41911f0 into develop May 30, 2024
7 checks passed
@CurryYangxx CurryYangxx deleted the perf/poor-network-improvement branch May 30, 2024 13:35
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
@CurryYangxx @stefancruz
perf: io-parallelization (Kong#7458)
f677fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

@ihexxa ihexxa ihexxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CurryYangxx @gatzjames @ihexxa