Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Key-Value Editor): Improve accessibility and make the items re-orderable #7465

Merged
merged 9 commits into from
Jun 5, 2024
Merged

feat(Key-Value Editor): Improve accessibility and make the items re-orderable #7465

merged 9 commits into from
Jun 5, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented May 29, 2024 •
edited
Loading

Highlights:

  • The key-value editor is now inside a gridlist and has more accessible keyboard navigation for actions and re-ordering
  • Key-value pairs can now be re-ordered with keyboard/drag-and-drop interactions

Extras:

  • Cleans up unused components
  • Fix height of graphql editor

TODO:

  • Updating the list of key-value pairs should happen on an event instead of a useEffect during render

Closes #5686

@gatzjames gatzjames force-pushed the feature/ins-3868-add-back-the-ability-to-reorder-query-parameters branch 3 times, most recently from e11fae1 to 4d9fa98 Compare June 3, 2024 14:52
@gatzjames gatzjames self-assigned this Jun 4, 2024
@gatzjames gatzjames requested a review from a team June 4, 2024 09:59
@gatzjames gatzjames force-pushed the feature/ins-3868-add-back-the-ability-to-reorder-query-parameters branch 3 times, most recently from 18ff492 to f9cd7aa Compare June 4, 2024 18:08
@gatzjames gatzjames force-pushed the feature/ins-3868-add-back-the-ability-to-reorder-query-parameters branch from f9cd7aa to c083acc Compare June 5, 2024 07:12
@gatzjames gatzjames force-pushed the feature/ins-3868-add-back-the-ability-to-reorder-query-parameters branch from 5a4c436 to 0ca0052 Compare June 5, 2024 08:16
@gatzjames gatzjames enabled auto-merge (squash) June 5, 2024 08:22
@gatzjames gatzjames merged commit 978fbcf into Kong:develop Jun 5, 2024
7 checks passed
@gatzjames gatzjames deleted the feature/ins-3868-add-back-the-ability-to-reorder-query-parameters branch June 5, 2024 08:30
saisatishkarra pushed a commit that referenced this pull request Jun 5, 2024
@gatzjames @saisatishkarra
feat(Key-Value Editor): Improve accessibility and make the items re-o…
f000188 
…rderable (#7465)

* remove unused components

* make read-only editors display nunjucks

* graphql toolbar css

* re-orderable key value editor

* move onChange to event handlers

* remove unused test

* fix delete all/add updates

* clean up logs

* remove callbacks
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jun 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'id') ?(ui/components/key-value-editor/key-value-editor) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurryYangxx CurryYangxx CurryYangxx approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can no longer reorder headers in the request panel
2 participants
@gatzjames @CurryYangxx