chore: bake inso-cli on older macos [INS-3931] #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
filfreire
force-pushed
the
chore/force-older-macos-on-release
branch
from
6fbcc71
to
876dbd5
Compare
jackkav
reviewed
Jun 3, 2024
|
|
Is there a reason it needs to also run the macos-14 build? Its not good to support multiple builds when one will suffice. Makes things less intuitive. |
|
@jackkav we can make it macos-13 only as its better for compatibility |
filfreire
force-pushed
the
chore/force-older-macos-on-release
branch
from
4fa9ece
to
dcd6f2b
Compare
This reverts commit dcd6f2b.
filfreire
commented
Jun 3, 2024
filfreire
commented
Jun 4, 2024
jackkav
approved these changes
Jun 4, 2024
saisatishkarra
pushed a commit
that referenced
this pull request
Jun 5, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
* chore: bake inso-cli on older macos [INS-3931] * send PKG_NAME var for macos builds * macos-13 only * Revert "send PKG_NAME var for macos builds" This reverts commit dcd6f2b. * Update .github/workflows/release-start.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
macos-latestnow defaults tomacos-14that uses apple sillicon. When we bake inso cli on apple sillicon we screw compatibility with all other macos versions that run on intel.In a follow-up PR we can do something similar for ubuntu
Closes INS-3931
Tested in https://github.com/Kong/insomnia/releases/tag/v9.3.0-alpha.0-experimental
Related pr - #7469 where we tested this