fix: add a missing assertion chain for the response entity - INS-3917 #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
approved these changes
Jun 3, 2024
jackkav
approved these changes
Jun 3, 2024
gatzjames
reviewed
Jun 3, 2024
| @@ -140,7 +139,7 @@ export async function initInsomniaObject( | |||
| const variables = new Variables({ | |||
| globals, | |||
| environment, | |||
| collection: collectionVariables, | |||
| collection: baseEnvironment, | |||
There was a problem hiding this comment.
Is collection accepting environments? If so maybe we should change the name to make more clear
There was a problem hiding this comment.
Good catch, it tries to keep one one base environment instance so that operations triggered from variables would also be applied to the base environment.
Let me start another PR to rename them.
ihexxa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
insomnia.response.to.not.have.status(200);collectionVariablesandbaseEnvironmentso that operations triggered from different entities will take effect.Ref: - INS-3917