chore: add analytics test [INS-3919] #7478
Merged
+121
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
changed the title
filfreire
force-pushed
the
feature/ins-3919-analytics-test
branch
from
40c776b
to
2c5a420
Compare
gatzjames
force-pushed
the
feature/ins-3919-analytics-test
branch
from
37a3e8f
to
971eef4
Compare
gatzjames
approved these changes
Jun 5, 2024
filfreire
force-pushed
the
feature/ins-3919-analytics-test
branch
from
53931a9
to
c59c417
Compare
filfreire
force-pushed
the
feature/ins-3919-analytics-test
branch
from
c59c417
to
c6779bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some thoughts:
final approach - capture segment network events, and check for userId and anonymousId in test
We could try to find a hack to force the "fetcher" used by the segment lib to use insomniafetch, and on playwright we would capture the segment events and look into them - for now didn't explore this - not sure if it's worth exploring(initial approach followed) added a "debug" console log when insomnia is running via playwright, which we can capture on a test and check if certain bits of data are properly sent on logged in or logged out - it's not a beautiful option, but could do the jobCloses INS-3919