fix: url preview should contain auth params #7509
Merged
+78
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
reviewed
Jun 7, 2024
| @@ -33,24 +33,38 @@ interface Props { | |||
|
|
|||
| const defaultPreview = '...'; | |||
|
|
|||
| function getQueryParamsFromAuth(auth: RequestAuthentication | {}): RequestParameter[] { | |||
| if (!('type' in auth)) { | |||
There was a problem hiding this comment.
if (!auth.type) {} seems easier to read
There was a problem hiding this comment.
I built a helper for this getAuthObjectOrNull if this equals null that means auth is not set or empty object or doesn't have .type I've made a suggestion for the change but please test it to confirm. These cases are all possible because request groups can have auth objects but existing ones are uninitialised and therefore undefined. In this case it shouldn't show so perhaps you don't need it.
Suggested change
| if (!('type' in auth)) { | |
| if (getAuthObjectOrNull(auth) === null) { |
There was a problem hiding this comment.
Sure, let me also test this later.
There was a problem hiding this comment.
this also should preview auth fields coming from folders above
jackkav
previously approved these changes
Jun 7, 2024
jackkav
approved these changes
Jun 10, 2024
jackkav
force-pushed
the
fix-preview-auth
branch
from
016d58b
to
02205c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes: #7235
Ref: INS-3966