Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Database types): Infer query params from database model #7512

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore(Database types): Infer query params from database model #7512

merged 1 commit into from
Jun 7, 2024

Conversation

gatzjames
Copy link
Contributor

Highlights:

  • Adds a generic type to the database Query type. This allows us to safely query specific properties of any database model
  • Removes a bunch of ts-expect-error

@gatzjames gatzjames self-assigned this Jun 7, 2024
@gatzjames gatzjames requested a review from a team June 7, 2024 09:16
@gatzjames gatzjames enabled auto-merge (squash) June 7, 2024 10:27
@jackkav jackkav disabled auto-merge June 7, 2024 10:32
@jackkav jackkav merged commit 48eea15 into Kong:develop Jun 7, 2024
2 checks passed
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
@gatzjames @stefancruz
improve database types to allow for querying per model fields (Kong#7512
cd1b8fb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

@filfreire filfreire filfreire approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gatzjames @jackkav @filfreire