Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Key-Value Editor): UX improvements and bugfix for empty state #7541

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jun 13, 2024

Highlights:

  • Fixes a bug where editing the key/value of the empty state field would trigger an infinite re-render. Also simplified the code and logic for showing the empty state placeholder.
  • Switching to another input field doesn't require to click outside now
  • Improved highlight styles
  • Clicking on an option from the auto-complete keeps the focus to the input and adds the value as expected

Closes INS-4001

@gatzjames gatzjames merged commit a79dc36 into Kong:develop Jun 13, 2024
7 checks passed
@gatzjames gatzjames deleted the fix/key-value-editor-bug branch June 13, 2024 12:03
Copy link

sentry-io bot commented Jun 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Expected fetch controller: :r3v: Array.forEach(<anonymous>) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants