transform hyphens to underscores on import #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
changed the title
ihexxa
previously approved these changes
Jun 20, 2024
| // Use a regular expression to find and replace the pattern | ||
| return input.replace(/\{\{([^\}]+)\}\}/g, (_, match) => { | ||
| // Replace hyphens with underscores within the match | ||
| const replaced = match.replace(/-/g, '_'); |
There was a problem hiding this comment.
nit: replaceAll might improve the performance a bit.
There was a problem hiding this comment.
jackkav
force-pushed
the
feature/ins-4041-nunjucks-bug
branch
from
323dc30
to
dc840f2
Compare
CurryYangxx
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to import variables from postman with keys such as one-two-three we need to transform them to one_two_three because our nunjucks library is expecting js object syntax, for example in a js console : (notice the color difference)
reviewer notes: there might be some cases where the regex doesn't work the way I expect.
the postman types and inconsistent and could be using @types/postman-collection
Related to INS-4041