Statically link libcurl on Linux builds #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschier
changed the title
…mnia into build/static-curl-linux
luizmariz
pushed a commit
to luizmariz/insomnia
that referenced
this pull request
Jan 22, 2020
* Statically linked Curl for linux builds with Docker * Test Travis Docker * Try fix blocking i/o * Try a package * Fixed linux build * Try hack * Fix icons? * Icon color * Re-enable osx builds * Remove libcurl3 dependency requirements * Update electronbuilder config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Linux builds to link
libcurlstatically instead of relying on sketchy shared libraries that may or may not be the correct version. This change was prompted by the recent Ubuntu 18.04 update that bumped it'slibcurldependency from 3 to 4, effectively breaking Insomnia for everyone.