Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Feature request: Add supporting for "uber-trace-id" header. #22

Closed
longit644 opened this issue Oct 8, 2018 · 5 comments
Closed

Feature request: Add supporting for "uber-trace-id" header. #22

longit644 opened this issue Oct 8, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@longit644
Copy link
Contributor

longit644 commented Oct 8, 2018

When using Kong Zipkin plugin with Jaeger client without B3TextMapCodec, Jaeger can't aggregate spans and services span:

screen shot 2018-10-09 at 6 31 59 am

To flexibility support integrating multiple tracing system (jaeger, zipkin) with Kong.
Let's support extracting span from Tracing Context header like uber-trace-id header when unable extracting from X-B3-... headers in the request, and also injecting Kong's span context to uber-trace-id as well as current X-B3-... headers to upstream request headers.

@james-callahan
Copy link
Contributor

I'd like to have the option of different propagation formats (see also #21): to make the change I think we may need to break up the plugin into multiple plugins where you separately enable extractors, injectors and reporters.

To make coordination between these different plugins consistent, I'm looking into if we should add things to the Kong PDK.

@subnetmarco subnetmarco reopened this Jan 9, 2019
@Roberttmoon
Copy link

Is there any news on this? We use Jeager tracing and while we can collect the Zipkin trace from kong, we are having a bear of a time aggregating the traces together. It would be awesome to find out if theres any news on this issue.

@wpjunior
Copy link

wpjunior commented Dec 6, 2019

Hi!, my team at Globo.com have some troubles to use this plugin, the default behavior of many applications is to use uber-trace-id, @gszr and @kikito how could we improve this plugin to achieve this feature?

@jcchavezs
Copy link
Contributor

jcchavezs commented Dec 9, 2019

This is the kong-plugin-zipkin, isn't it better to request this feature in an opentracing plugin or create a plugin for Jaeger? I honestly don't think this plugin should support such a thing. On top of that jaeger also supports b3 so that could be also an option.

@kikito
Copy link
Member

kikito commented Feb 3, 2021

This was implemented in #101

@kikito kikito closed this as completed Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants