Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Connections in dependency graph, should it be like this? #53

Closed
Igor-lkm opened this issue Oct 30, 2019 · 2 comments
Closed

Connections in dependency graph, should it be like this? #53

Igor-lkm opened this issue Oct 30, 2019 · 2 comments

Comments

@Igor-lkm
Copy link

Igor-lkm commented Oct 30, 2019

My apologies if this is expected behaviour 馃帺

My setup:

  1. Create service on Kong
  • name: gateway-service-a
  • url http://service-a:3000,
  1. Kong: Add zipkin plugin to this service.
  • default service name: kong-gateway
  1. Service A: node.js koa app with zipkin-instrumentation-koa (traces incoming HTTP requests)
  • localServiceName: service-a

Dependency, which would be created on http request, looks like:

gateway-service-a ----- service-a

So we can add more services, and we would get:

gateway-service-a ----- service-a
gateway-service-b ----- service-b

Goes to this pattern:
{service-name-on-kong} ----- {localServiceName}

What I would expect in graph (both services are connect to Kong, not services on Kong):

      kong-gateway  ------ service-a
            |
        service-b

Or even better:

      kong-gateway ------ gateway-service-a  ------ service-a
            |
      gateway-service-b
            |
        service-b

Even trace looks like this in UI:

Screenshot 2019-10-30 at 17 03 56

kong-gateway directly to service-a. You have gateway-service-a when you would open service-a span

So the questing is should it be
{service-name-on-kong} ----- {localServiceName}
or
{kong-gateway} ----- {localServiceName}
or
{kong-gateway} ----- {service-name-on-kong} ----- {localServiceName}
?

Thank you!

@jcchavezs
Copy link
Contributor

@Igor-lkm there have been changed in the tags and endpoints (see #55). Would you recheck if this is still an issue?

@Igor-lkm
Copy link
Author

Igor-lkm commented Feb 27, 2020

@jcchavezs that was more a question or discussion rather than an issue.

For all the spans created by the plugin, the localEndpoint is now { serviceName = "kong" }

That sounds reasonable.

I think the issue might be closed. Thank you! 馃憤

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants