Skip to content

Commit

Permalink
fix(ai-proxy): invalid precedence on model tuning params
Browse files Browse the repository at this point in the history
  • Loading branch information
tysoekong committed Jun 10, 2024
1 parent 78edb87 commit 7d54c33
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
9 changes: 4 additions & 5 deletions kong/llm/drivers/anthropic.lua
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ local transformers_to = {
return nil, nil, err
end

messages.temperature = request_table.temperature or (model.options and model.options.temperature) or nil
messages.max_tokens = request_table.max_tokens or (model.options and model.options.max_tokens) or nil
messages.temperature = (model.options and model.options.temperature) or request_table.temperature or nil
messages.max_tokens = (model.options and model.options.max_tokens) or request_table.max_tokens or nil
messages.model = model.name or request_table.model
messages.stream = request_table.stream or false -- explicitly set this if nil

Expand All @@ -110,9 +110,8 @@ local transformers_to = {
return nil, nil, err
end

prompt.temperature = request_table.temperature or (model.options and model.options.temperature) or nil
prompt.max_tokens_to_sample = request_table.max_tokens or (model.options and model.options.max_tokens) or nil
prompt.model = model.name
prompt.temperature = (model.options and model.options.temperature) or request_table.temperature or nil
prompt.max_tokens_to_sample = (model.options and model.options.max_tokens) or request_table.max_tokens or nil
prompt.model = model.name or request_table.model
prompt.stream = request_table.stream or false -- explicitly set this if nil

Expand Down
4 changes: 2 additions & 2 deletions kong/llm/drivers/openai.lua
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ end

local transformers_to = {
["llm/v1/chat"] = function(request_table, model_info, route_type)
request_table.model = request_table.model or model_info.name
request_table.model = model_info.name or request_table.model
request_table.stream = request_table.stream or false -- explicitly set this
request_table.top_k = nil -- explicitly remove unsupported default

return request_table, "application/json", nil
end,

["llm/v1/completions"] = function(request_table, model_info, route_type)
request_table.model = model_info.name
request_table.model = model_info.name or request_table.model
request_table.stream = request_table.stream or false -- explicitly set this
request_table.top_k = nil -- explicitly remove unsupported default

Expand Down
2 changes: 1 addition & 1 deletion kong/llm/drivers/shared.lua
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ function _M.to_ollama(request_table, model)

-- common parameters
input.stream = request_table.stream or false -- for future capability
input.model = model.name
input.model = model.name or request_table.name

if model.options then
input.options = {}
Expand Down

0 comments on commit 7d54c33

Please sign in to comment.