[refactor] dao prepare #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
refactor/dao-prepare
branch
from
354d866
to
2e9c28f
Compare
squash of: [WIP][refactor] trying to prepare statements on the go [WIP][refactor] all queries prepared on the go - running :prepare is now optional - all daos (from plugins too) are using self._queries to reference queries that will then be prepared - remove preparation in find_by_keys because _execute already prepares [WIP][refactor] allow _queries to contain strings fix: cache key differing because of stripping
:prepare might disappear in the future.
thibaultcha
force-pushed
the
refactor/dao-prepare
branch
from
055f9fb
to
1947fc1
Compare
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[refactor] dao prepare
hutchic
added a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as an improvement for developing #147, but it's also useful to fix #11. It's a small refactor, to avoid having to call
:prepareevery time a DAO is instantiated.Changes:
:prepareat startup anymore. Statements will be dynamically prepared if they were not already. This is a step towards fixing When Cassandra is temporarily down make sure the connection is resumed #11, and having a more usable DAONotes:
:prepareis still called inkong.luawhen Kong starts, as a simple way of checking all statements are valid.:preparemight disappear in the future.