key-auth plugin returns error when key is set with empty value

[jameswestnz]

Summary

The key-auth plugin returns an error (shown below) when the apikey header is set with an empty value. While the fix could be to ensure the client does not pass an empty apikey, I feel the expected result should be either:

1. Kong resolves and continues with the anonymous consumer (if defined); or
2. Throw a 40X as if the apikey was never set

Steps To Reproduce

1. Configure the key-auth plugin globally, or on a specific service/route
2. Configure a consumer & key as per plugin instructions (https://docs.konghq.com/hub/kong-inc/key-auth/)
3. Send a request to the route's URL with a present (but empty) apikey header

Additional Details & Logs

Kong version: 1.0.3
Error thrown in the logs: [kong] handler.lua:159 [key-auth] failed to get from node cache: [postgres] length must be at least 1

[shugydw]

This issue may or may not be related to the issue I am facing (https://discuss.konghq.com/t/key-authentication-is-not-working/3034)

I am passing the correct apikey in query string (and tested in header as well). The requests are 401 Unauthorized.

Kong: Docker 1.0.3-alpine
Database: Docker Postgres 11.2-alpine
I don't recall any error such as yours.

[jameswestnz]

This seems to be the block throwing the exception: https://github.com/Kong/kong/blob/master/kong/plugins/key-auth/handler.lua#L158-L161

I'm experiencing an HTTP status code of 500 with a body of An unexpected error occurred - I think this is the only place (in this plugin) where we return an unconstructed body as a response.

Does the block above get caught here?: https://github.com/Kong/kong/blob/master/kong/plugins/key-auth/handler.lua#L203

I'll take a look if I can free up some time - just sharing thoughts in case they help!

[jameswestnz]

Untested, but I think adjusting https://github.com/Kong/kong/blob/master/kong/plugins/key-auth/handler.lua#L158-L161 to the following will fix the issue:

if err then
  kong.log.err(err)
  return nil, { status = 500, message = "An unexpected error occurred" }
end

[shugydw]

This issue may or may not be related to the issue I am facing (https://discuss.konghq.com/t/key-authentication-is-not-working/3034)

I am passing the correct apikey in query string (and tested in header as well). The requests are 401 Unauthorized.

Kong: Docker 1.0.3-alpine
Database: Docker Postgres 11.2-alpine
I don't recall any error such as yours.

My issue is caused by Konga - pantsel/konga#369

[cuongndc]

@shugydw, I have been the same issue, any ideas for your problem? Thanks!