Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins system #50

Closed
thibaultcha opened this issue Mar 3, 2015 · 4 comments
Closed

Plugins system #50

thibaultcha opened this issue Mar 3, 2015 · 4 comments
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.
Milestone

Comments

@thibaultcha
Copy link
Member

Separate plugins from the core repo.

@thibaultcha thibaultcha added this to the 0.1.0-beta2 milestone Mar 3, 2015
@subnetmarco
Copy link
Member

This also requires separating the authentication plugins (query/basic/header) and the network log plugins (tcp/udp)

@thibaultcha
Copy link
Member Author

Writing down the results of our recent discussions:

I think our best current option is to consider Kong not as a dependency, but as a requirement, like a container, the same way openresty is required for Kong.

If Kong is installed on the machine, we can require any of its tools (require "kong.utils.timestamps") or use the globaldao_factory` (or accept a constructor with it) in the plugin's code or tests.

From there, our current solution is to sign official plugins to approve they are safe (as mentioned in #18) and users would install them with luarocks, and specify them in their kong.yml file along with needed properties if any.

@thibaultcha thibaultcha modified the milestones: 0.2.0-beta, 0.1.0-beta Mar 19, 2015
@subnetmarco
Copy link
Member

Plugins have been separated with #82 , but they are still living in the same repo. To separate them in a separate repo we need to move kong to luarocks as mentioned in #83.

@thibaultcha thibaultcha added proxy idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports. and removed TODO labels Mar 25, 2015
@thibaultcha
Copy link
Member Author

#93 Has a more descriptive comment of what is needed for plugins.

javierguerragiraldez pushed a commit that referenced this issue Sep 3, 2021
Treat the localhost name special by always injecting it, according
to RFC 6761: Section 6.3.3

fixes #50
gszr pushed a commit that referenced this issue Oct 26, 2021
gszr pushed a commit that referenced this issue Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.
Projects
None yet
Development

No branches or pull requests

2 participants