feat(proxy): error templates customization #10374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszr
reviewed
Feb 26, 2023
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
from
312f7a2
to
e30d4ce
Compare
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
from
e30d4ce
to
f751f85
Compare
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
from
63066ad
to
489f289
Compare
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
from
489f289
to
99b48cb
Compare
Closed
hanshuebner
requested changes
Feb 28, 2023
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
2 times, most recently
from
84d2544
to
28f236c
Compare
Allow customizing error templates via kong.configuration parameters
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
2 times, most recently
from
efa79f4
to
6638e21
Compare
hanshuebner
requested changes
Mar 1, 2023
honor Accept header values based on their q-values weights
samugi
force-pushed
the
feat/kag-751-custom-error-templates
branch
from
6638e21
to
ea1828f
Compare
3 tasks
hanshuebner
approved these changes
Mar 3, 2023
esatterwhite
reviewed
Mar 3, 2023
Comment on lines
+581
to
+584
| error_template_html = { typ = "string" }, | ||
| error_template_json = { typ = "string" }, | ||
| error_template_xml = { typ = "string" }, | ||
| error_template_plain = { typ = "string" }, |
There was a problem hiding this comment.
@hanshuebner
What data gets passed to these templates?
There was a problem hiding this comment.
@esatterwhite the templates are rendered by passing them the error message as a string, see here for example. We will provide proper documentation before this is released.
hanshuebner
pushed a commit
that referenced
this pull request
Mar 6, 2023
* feat(proxy): error templates customization Allow customizing error templates via kong.configuration parameters * tests(pdk): initialize kong global to fix failing tests * chore(*): changelog * fix(proxy): honor Accept values weights honor Accept header values based on their q-values weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow customizing error templates via kong.configuration parameters
Checklist
Full changelog
Issue reference
Fix #7093
KAG-723
KAG-751