fix(plugin): do not shorten id when not w3c #10531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
from
9b4cc86
to
4d92ef2
Compare
ghost
reviewed
Mar 21, 2023
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
from
e91bc9b
to
3da00da
Compare
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
5 times, most recently
from
f183489
to
3eb782f
Compare
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
from
96a8ae0
to
a4e10e6
Compare
samugi
reviewed
Mar 29, 2023
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
4 times, most recently
from
22b1847
to
a450983
Compare
samugi
reviewed
Apr 4, 2023
hbagdi
reviewed
Apr 4, 2023
hbagdi
reviewed
Apr 4, 2023
| end | ||
|
|
||
| return trace_id | ||
| end |
There was a problem hiding this comment.
It would better if we have a single "to_provider_trace_id(trace_id,provider_type)" and unit test the heck out of it instead of ensuring that we call the right function in the right if branch below.
Not a blocker for this PR.
There was a problem hiding this comment.
Agree. But let's wait until another larger round of refactoring to fix long-term issues.
StarlightIbuki
commented
Apr 13, 2023
StarlightIbuki
commented
Apr 13, 2023
StarlightIbuki
commented
Apr 13, 2023
Co-authored-by: Harry <harrybagdi@gmail.com> Co-authored-by: Samuele Illuminati <samuele@konghq.com>
StarlightIbuki
force-pushed
the
fix/shorten-w3c
branch
from
af77d59
to
4991dca
Compare
samugi
approved these changes
Apr 13, 2023
|
ready to cherry-pick on EE @StarlightIbuki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug was introduced when trying to fix the tracing ID length issue.
We should only adjust the ID for specific headers instead of before calling
propagate.Checklist
Issue reference
Fix KAG-652