Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status_api): readiness status endpoint #10610

Merged
merged 142 commits into from
Apr 25, 2023
Merged

feat(status_api): readiness status endpoint #10610

merged 142 commits into from
Apr 25, 2023

Conversation

pluveto
Copy link
Contributor

@pluveto pluveto commented Apr 4, 2023

Summary

Checklist

Docs

  1. autodoc/admin-api/data/admin-api.lua
  2. [DOCU-2921] Status endpoint + Kong health check docs.konghq.com#5419

Full changelog

  • Add status endpoint

Issue reference

Fix KAG-76 KAG-1045

kong/api/routes/health.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
@chronolaw
Copy link
Contributor

We also need test cases and change log entry for this PR.

autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
kong/api/routes/health.lua Outdated Show resolved Hide resolved
kong/api/routes/health.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw changed the title feat: [WIP POC] status endpoint feat(adminapi): [WIP POC] status endpoint Apr 4, 2023
@hbagdi
Copy link
Member

hbagdi commented Apr 4, 2023

Please convert this into a draft PR.

@pluveto pluveto marked this pull request as draft April 5, 2023 03:52
kong/runloop/handler.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
@pluveto
Copy link
Contributor Author

pluveto commented Apr 7, 2023

moved to status api

@github-actions github-actions bot added changelog chore Not part of the core functionality of kong, but still needed core/clustering core/pdk core/tracing labels Apr 7, 2023
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only blocker of this PR is Kong/docs.konghq.com#5419

CHANGELOG.md Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
autodoc/admin-api/data/admin-api.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
kong/status/ready.lua Outdated Show resolved Hide resolved
kong/status/ready.lua Outdated Show resolved Hide resolved
kong/status/ready.lua Outdated Show resolved Hide resolved
kong/status/ready.lua Outdated Show resolved Hide resolved
pluveto and others added 11 commits April 24, 2023 17:17
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
kong/runloop/handler.lua Outdated Show resolved Hide resolved
kong/runloop/handler.lua Outdated Show resolved Hide resolved
pluveto and others added 3 commits April 25, 2023 10:56
Co-authored-by: Chrono <chrono_cpp@me.com>
Co-authored-by: Chrono <chrono_cpp@me.com>
@pluveto
Copy link
Contributor Author

pluveto commented Apr 25, 2023

The master branch itself has problems. Let's wait it to be fixed.

@dndx dndx dismissed locao’s stale review April 25, 2023 07:43

tests fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants