feat(zipkin): use queues to send data to zipkin server #10753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshuebner
force-pushed
the
feat/zipkin-queues
branch
from
52cf198
to
a244520
Compare
bungle
reviewed
Apr 26, 2023
hanshuebner
force-pushed
the
feat/zipkin-queues
branch
from
a244520
to
b824dd8
Compare
jschmid1
reviewed
Apr 26, 2023
hanshuebner
force-pushed
the
feat/zipkin-queues
branch
from
b824dd8
to
b8e8e8f
Compare
Yes, the CI spins up a real zipkin. |
jschmid1
approved these changes
Apr 26, 2023
Previously, the zipkin plugin performed some internal buffering to group spans from one requests together before sending them to the zipkin server. This buffer has replaced by using a plugin queue. The normal queueing parameters can be used to control the batching behavior.
hanshuebner
force-pushed
the
feat/zipkin-queues
branch
from
b8e8e8f
to
9baecad
Compare
kikito
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the zipkin plugin performed some internal buffering to group spans from one requests together before sending them to the zipkin server. This buffer has replaced by using a plugin queue. The normal queueing parameters can be used to control the batching behavior.
Checklist
Issue reference
KAG-322