fix(queues): validate queue parameters more strictly #10840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
reviewed
May 10, 2023
hanshuebner
force-pushed
the
fix/kag-1313-queue-parameter-types
branch
from
36881c1
to
453a7e0
Compare
samugi
approved these changes
May 11, 2023
chronolaw
reviewed
May 12, 2023
StarlightIbuki
approved these changes
May 12, 2023
hanshuebner
force-pushed
the
fix/kag-1313-queue-parameter-types
branch
from
453a7e0
to
7efdef3
Compare
bungle
approved these changes
May 12, 2023
hanshuebner
added a commit
that referenced
this pull request
Jun 2, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
3 tasks
hanshuebner
added a commit
that referenced
this pull request
Jun 2, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
hanshuebner
added a commit
that referenced
this pull request
Jun 5, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
hanshuebner
added a commit
that referenced
this pull request
Jun 5, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
hanshuebner
added a commit
that referenced
this pull request
Jun 5, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
jschmid1
pushed a commit
that referenced
this pull request
Jun 9, 2023
In #10840, some queue parameter types were changed so that values were more restricted than in the original schema. This commit adds a data migration so that any values that would not be valid according to the new schema are updated. Testing this migration is done with an integration test rather than using the upgrade tests logic because the latter does not currently support testing upgrades in a way that'd be required for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change, queue parameters are validated more strictly:
max_batch_size,max_entriesandmax_bytesare declared as integers, not numbersinitial_retry_delayandmax_retry_delayare specified to be positive numbers larger than 0.001 (seconds)The schema validation code required a small change so that
betweenspecifiers could usenumbers. Previously, onlyintegers were allowed, which was inappropriate for the queue schema.Checklist
Issue reference
KAG-1313