Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api/status): remove the database status in dbless mode and data-plane #10995

Merged
merged 4 commits into from Jun 9, 2023
Merged

fix(api/status): remove the database status in dbless mode and data-plane #10995

merged 4 commits into from Jun 9, 2023

Conversation

AndyZhang0707
Copy link
Collaborator

@AndyZhang0707 AndyZhang0707 commented Jun 2, 2023 •
edited by jira bot

Summary

Remove the meaningless database status information from the status API when operating in dbless mode or data plane.

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix FTI-5034

@AndyZhang0707 AndyZhang0707 changed the title Fix/fix db status fix(status): remove the database status in dbless mode and data-plane Jun 2, 2023
@chronolaw chronolaw changed the title fix(status): remove the database status in dbless mode and data-plane fix(api/status): remove the database status in dbless mode and data-plane Jun 2, 2023
@chronolaw
Copy link
Contributor

How about setting database: false? perhaps it is better than removing database field?

@AndyZhang0707
Copy link
Collaborator Author

The database is irrelevant in the dbless mode and data-plane. Leaving the information there may lead to some confusions and the customer may need to think/investigate why it's not reachable. So I'd prefer removing the irrelevant information from the status api completely to eliminate the confusion, but I'm open for suggestions.

@chronolaw
Copy link
Contributor

The database is irrelevant in the dbless mode and data-plane. Leaving the information there may lead to some confusions and the customer may need to think/investigate why it's not reachable. So I'd prefer removing the irrelevant information from the status api completely to eliminate the confusion, but I'm open for suggestions.

It looks reasonable.

chronolaw
chronolaw reviewed Jun 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@AndyZhang0707 AndyZhang0707 force-pushed the fix/fix-db-status branch 2 times, most recently from 2721020 to bfc0eef Compare June 7, 2023 06:27
@AndyZhang0707
fix(status): remove the database status in dbless mode and data-plane
ad95b1e 
Remove the meaningless database status information from the status
API when operating in dbless mode or data plane.
@AndyZhang0707
fix(status): remove the database status in dbless mode and data-plane
ec89f1c 
Remove the meaningless database status information from the status API
when operating in dbless mode or data plane.
@AndyZhang0707
Address review comments
959517b 
Add PR to the changelog and also format the code a little bit.
@AndyZhang0707
Update CHANGELOG
7e53e37
@windmgc windmgc merged commit 1ab321a into master Jun 9, 2023
21 checks passed
@windmgc windmgc deleted the fix/fix-db-status branch June 9, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@oowl oowl oowl approved these changes

Assignees

@AndyZhang0707 AndyZhang0707

Labels
changelog core/admin-api size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndyZhang0707 @chronolaw @oowl @windmgc