perf(plugin/prometheus): generate metrics string with string.buffer #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
force-pushed
the
perf/prometheus-exporter-with-string-buffer
branch
from
b02ec95
to
6e3cf0c
Compare
bungle
requested changes
Jun 9, 2023
|
@oowl , could you do the same performance test for this PR again? thanks. |
bungle
approved these changes
Jun 9, 2023
bungle
requested changes
Jun 13, 2023
bungle
force-pushed
the
perf/prometheus-exporter-with-string-buffer
branch
from
2269692
to
9d7568f
Compare
bungle
approved these changes
Jun 13, 2023
3 tasks
windmgc
pushed a commit
that referenced
this pull request
Jun 25, 2023
…fer (#11065) This PR follows #11040, continue to optimize the string usage by string.buffer. KAG-1852 Full changelog - use table.new for seen_metrics - buffered_print() outputs a string, not a table - change printable_metric_data of stream to fit the new buffered_print() - do not use ipairs to iterate array - other small optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This a performance improvement of #10949, using
string.bufferto generate metrics string,eliminate the cost of huge table.
KAG-1783
Checklist
Full changelog
table.newstring.buffergsubfor string value